Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cover ---> concealment #72739

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

RenechCDDA
Copy link
Member

Summary

Interface "Tile cover is now named concealment, because that's all it actually does."

Purpose of change

Many, many many people have confused terrain/furniture cover for interacting with projectiles. It does not interact with projectiles in any way.

Describe the solution

Change the display name to make it really obvious

Describe alternatives you've considered

I originally called it "Vision" and slapped a negative sign on it
image

Testing

image

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 31, 2024
@ashGlaw
Copy link
Contributor

ashGlaw commented Mar 31, 2024

Good clarify, that's much clearer, at least to me

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 31, 2024
@I-am-Erk I-am-Erk merged commit 9b661f1 into CleverRaven:master Apr 4, 2024
24 of 28 checks passed
@I-am-Erk I-am-Erk added the 0.H Backport PR to backport to the 0.H stable release canddiate label Apr 4, 2024
@RenechCDDA RenechCDDA deleted the better_name_for_cover branch April 4, 2024 06:25
@Procyonae Procyonae mentioned this pull request May 14, 2024
@Procyonae Procyonae added 0.H Backported and removed 0.H Backport PR to backport to the 0.H stable release canddiate labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.H Backported astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants